Add MPS Pytorch support for batched_mask_to_box function #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so we can fix a bug affecting our code
…t output is incorrect
…t masks produce incorrect results)
|
Update: I did make an issue facebookresearch/segment-anything#552 |
constantinpape
approved these changes
Sep 7, 2023
|
Thanks for all this @GenevieveBuckley, and also for finding the relevant PRs in SAM. I agree with your strategy: let's see if they fix these issues on the SegmentAnything side and until then we keep the vendored function. |
constantinpape
merged commit 9e1e3bf
into
computational-cell-analytics:mps
1 check passed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an edited copy of the
batched_mask_to_box()function fromsegment_anything/utils/amg.pyto the micro-sam codebase. The function has been edited to solve two problems:The license for segment-anything is Apache 2.0, which is compatible with the MIT licence micro-sam uses.
Eventually, if this gets fixed upstream we can remove it from the micro-sam code and go back to using the
batched_mask_to_box()function directly from segment-anything. But that seems unlikely to happen soon.Added changes for MPS facebookresearch/segment-anything#122
batched_mask_to_box(). Creating an issue would be helpful here (maybe I'll try and do that this evening).Extra context: discussed here previously on the main PR for adding .MPS support to micro-sam.